[PD] bug with edit-mode (was Re: [PD-announce] PD 0.49-0test1 released)

Fri Sep 14 16:44:25 CEST 2018

I couldn't exactly reproduce your problem but I found a crasher bug with [donecanvasdialog( myself and this might be related: https://github.com/pure-data/pure-data/pull/467

Christof

Gesendet: Mittwoch, 12. September 2018 um 13:14 Uhr
Von: "JTG III" <jordanthomasgibbonsiii at gmail.com>
An: msp at ucsd.edu
Cc: pd-list at lists.iem.at
Betreff: Re: [PD] bug with edit-mode (was Re: [PD-announce] PD 0.49-0test1 released)

I am on Mac, yes, sorry I forgot to mention that. For me the problem is happening whenever a donecanvasdialog message is sent to a canvas, so I'd imagine that is triggering the same thing as the properties menu would?  Also, if the donecanvasdialog message happens in an abstraction, it puts whatever patch the abstraction was created in into edit mode, and this seems to be where it's going into edit mode sort of silently, as in, it doesn't say [edit] at the top of the screen and there's no checkmark next to edit mode in the edit menu, but if you try to click anywhere inside the patch its obviously in edit mode as you are able to select/resize/etc. items in the patch but aren't able to click on a bang, for example, or anything else--but I've only been able to reliably reproduce this when first opening a patch that sends a donecanvasdialog message upon opening. It's happened occasionally after the patch has been opened, but usually the top of the pd window will indicate [edit] at least when a donecanvasdialog message is sent. The crash upon closing the patch happens every time, though. I realize that the donecanvasdialog thing is an unsupported method or whatever, but it seems like the crashing might be part of a more general problem somewhere, maybe?

I've just tested 0.49-0test2-i386 just now and the crash and everything preceding it is still happening. I've attached a patch demonstrating how the problem is being triggered for me, if maybe someone with a mac wants to check it out to confirm. It should open in edit mode without the [edit] message appearing in the title bar or whatever its called or the edit mode option in the edit dropdown menu being checked, and then make the patch go into edit mode again each time the donecanvasdialog message is sent, and finally it should crash pd when the window is closed. 

ps - I seem to have mostly gotten around the issue by using coords instead of donecanvasdialog, which I normally do anyway, however it seems the crash is  happening regardless, but I'm not completely sure that I didn't miss anything so please take that as a very tentative statement. It might just be too early yet for my brain to have come online. 

On Tue, Sep 11, 2018 at 9:13 PM Miller Puckette <msp at ucsd.edu[mailto:msp at ucsd.edu]> wrote:I bet this is related to the "save as" crash bug.  Are you on Mac OSX?
And... am I reading this correctly that you (1) open any patch; (2) open the
"properties" dialog for the canvas; (3) hit "OK" on the dialog, and then
you find out that the patch went into edit mode?

(And that it then crashes Pd to close the patch?)

thanks
Miller

On Tue, Sep 11, 2018 at 07:08:30PM -0400, JTG III wrote:
> Okay I can can confirm that using donecanvasdialog is triggering the edit
> mode thing, though I'm not sure why there is no indication from pd upon
> loading a patch on startup that it is, in fact, in edit mode. I tried some
> patches made by other people, such as waveform.mmb or whatever it is
> called, and a couple of others and they all toggled edit mode on the parent
> patch.
> They also all cause pd to crash when the parent patch is closed. I didn't
> get any hints from the terminal but the script I usually use to start pd
> wasn't working for some reason and I have to head out again for an hour or
> two but I'll look into it more when I get back.
>
> On Sep 11, 2018 6:01 PM, "JTG III" <jordanthomasgibbonsiii at gmail.com[mailto:jordanthomasgibbonsiii at gmail.com]> wrote:
>
> > Well I know that the canvas is in edit mode as anytime I try to click
> > anything I end up grabbing something and resizing it instead, and toggling
> > edit mode on and off in the edit menu makes it behave as expected. The
> > thing with having no indication of currently being in edit mode was only
> > happening when I would first open the patch, and as mentioned I could tell
> > that it was in fact on because whenever I would try to click on anything in
> > the PD window with the mouse the cursor would instead select or start
> > resizing whatever was beneath it.
> > Thinking about it now I figure it must have something to do with
> > donecanvasdialog, would that make sense? I'm not using any gui plugins and
> > no externals are interacting with the gui, but I am using a number of
> > structs. I'll check that in a couple of hours when I'm back at home.
> >
> > On Sep 11, 2018 9:11 AM, "IOhannes m zmoelnig" <zmoelnig at iem.at[mailto:zmoelnig at iem.at]> wrote:
> >
> >> hi.
> >>
> >> thanks for the bug-report.
> >>
> >> unfortunately it indeed doesn't contain much information about what
> >> could be the actual problem you are experiencing.
> >>
> >> things i could establish:
> >> - your patches switch to edit-mode when they shouldn't
> >> - there is no indication of being in edit-mode
> >> - you accidentally resize GOPs
> >> - abstractions/subpatches send "messages"
> >> - you are using a number of externals
> >> - Pd sometimes crashes
> >> - the problem appears under Pd-0.49-0test1
> >> - everything works with Pd-0.48-2
> >> (i hope this is correct).
> >>
> >> so:
> >>
> >> how do you know that you are in edit-mode? what are the clues that make
> >> you believe that you end up in edit mode; what are the clues that are
> >> missing (so you don't immediately realize you are in edit mode)?
> >>
> >> what are these ominous "messages" being sent from abstractions/subpatches?
> >> in Pd you are always sending messages between objects; so there must be
> >> something special to yours. e.g. do they do some weirdo dynamic patching
> >> things?
> >>
> >> what externals are you using? do these externals interact with the GUI?
> >> are there any GUI-plugins involved?
> >>
> >> ghs,dr
> >> IOhannes
> >>
> >>
> >> _______________________________________________
> >> Pd-list at lists.iem.at[mailto:Pd-list at lists.iem.at] mailing list
> >> UNSUBSCRIBE and account-management -> https://lists.puredata.info/[https://lists.puredata.info/]
> >> listinfo/pd-list
> >>
> >>

> _______________________________________________
> Pd-list at lists.iem.at[mailto:Pd-list at lists.iem.at] mailing list
> UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list[https://lists.puredata.info/listinfo/pd-list]
 _______________________________________________ Pd-list at lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list[https://lists.puredata.info/listinfo/pd-list]