[PD] theme all the things

[Andre Osku Schmidt]

On Sat, 02 Jan 2021 14:47:53 +0100
IOhannes m zmölnig <zmoelnig at iem.at> wrote:

> Am 2. Jänner 2021 13:27:05 MEZ schrieb Andre Osku Schmidt <andre at osku.de>:
> > hello people,
> > 
> 
> > - is someone working on this already? (i haven't used pd in a
> > ~decade...)
> 
> check out: https://github.com/pure-data/pure-data/pull/196

but of course, i remember now... >.<*

well, at least i "learned" couple things while re-inventing the wheel ;P

sorry but i could not follow the hundreds of comments in that pull-request, what is there still todo?

fwiw, i agree that the scope should be kept minimal (i would even go as far as to not change tk(k) theme colors (it currently overwrites my tk(k) theme colors used by pd-window "terminal". but ultimately i don't actually care where i need to change the colors...))

not sure if i should comment on that pull-request that my "end-goal" would be to load the colors from system theme in /etc/whatever (and i assume some would like to load from ~/whatever & other os system/user config paths). and while i was doing my experiment, the "pkgIndex way" felt like a good place to add this new tcl code?

so maybe that pull-request could/should add the colors to tcl/pd_colors.tcl (or something, but instead tcl/pd-gui.tcl) and the system/user theme loading code could then later be added there?

but i don't actually know what i'm talking about, and mostly go by trial-and-error and "feel", so...

fwiw, i'll now keep using this pull-request (in case the merge is waiting for bug testing). it at least changes all the (and more) colors i need, cool!

cheerio
.oskude