[PD] hardcoded samplerate in audio example

[Patco]

 Sure, I could even make a PR if you like, I've attached a screenshot of the part from the patch where samplerate is hardcoded, on the second trigger outlet connected to [read-sample].
More confidently, I don't know how this could actually work with the [unpack s f] thing.

 The second screenshot is a correction that makes this patch compatible with any samplerate soundfile.

I've made this correction on apple silicon with pd 0.53.0 downloaded on official site but I guess this would happen in any version since this patch exist, and I've figured it out on compiled raspberryOS's pd 0.54 using sources cloned from pd's official github.





Best,

Pat

PS: thanks a lot for the else external, particulary the bandpass filter.

> Le 29 avr. 2023 à 15:49, Alexandre Torres Porres <porres at gmail.com> a écrit :
> 
> can you give details on what version of pd you have, and like a screenshot or something with the parameters? 
> 
> the code from that file does get the sample rate from the soundfile into an "insample" variable, so it looks like it should work, but I haven't thoroughly tested it yet.
> 
> you can also open an issue at
> 
> https://github.com/porres/pddp <https://github.com/porres/pddp>
> 
> sending us the sample you're using and everything.
> 
> cheers
> 
> Em sex., 28 de abr. de 2023 às 11:44, Patco <colet.patrice at gmail.com <mailto:colet.patrice at gmail.com>> escreveu:
> In fact we have encountered problems specifically with my favorite PureData patch, the phase-vocoder, used for many different purposes, particulary with location scrolling, usefull for network time-stretch sample reading, speed is not as same as original soundfile when samplerate is 48000hz.
> 
> best
> 
> Pat
> 
> > Le 24 avr. 2023 à 11:01, Miller Puckette <mpuckette at cloud.ucsd.edu <mailto:mpuckette at cloud.ucsd.edu>> a écrit :
> > 
> > Yep... these patches date back to before that outlet :)
> > 
> > For now it migth suffice to mention that the patches only work on 44k1 soundfiles... and incidentally, thee best one (teh phase vocoder) works fine on 48K files, you just have to adjust the transposition by 147 cents.
> > 
> > cheers
> > 
> > Miller
> > 
> > On 4/23/23 03:47, Patco wrote:
> >> Hello,
> >> 
> >>  I've found something awkward in all fft patches from 03.audio-examples that leads to mistakes.
> >> 
> >> Samplerate is hardcoded to 44100, so this wouldn't work correctly when opening soundfiles having another samplerate.
> >> 
> >>  This should be corrected by using [soundfiler] second outlet instead of hardcoding samplerate.
> >> 
> >> 
> >> _______________________________________________
> >> Pd-list at lists.iem.at <mailto:Pd-list at lists.iem.at> mailing list
> >> UNSUBSCRIBE and account-management -> https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-list__;!!Mih3wA!CrYdxPP1DIwgweOlVm1jAUnUVItz5JBMO7EMwJgmlAXY63111FtyJQ70TGNPREswXJC1Mfe2UL13YOoWnA4$ <https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-list__;!!Mih3wA!CrYdxPP1DIwgweOlVm1jAUnUVItz5JBMO7EMwJgmlAXY63111FtyJQ70TGNPREswXJC1Mfe2UL13YOoWnA4$>
> > 
> > 
> > 
> > _______________________________________________
> > Pd-list at lists.iem.at <mailto:Pd-list at lists.iem.at> mailing list
> > UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list <https://lists.puredata.info/listinfo/pd-list>
> 
> 
> 
> 
> _______________________________________________
> Pd-list at lists.iem.at <mailto:Pd-list at lists.iem.at> mailing list
> UNSUBSCRIBE and account-management -> https://lists.puredata.info/listinfo/pd-list <https://lists.puredata.info/listinfo/pd-list>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puredata.info/pipermail/pd-list/attachments/20230429/01d2c5ee/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samplerateHardcode.jpg
Type: image/jpeg
Size: 199885 bytes
Desc: not available
URL: <http://lists.puredata.info/pipermail/pd-list/attachments/20230429/01d2c5ee/attachment-0002.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: phase-vocoder-corrected.jpg
Type: image/jpeg
Size: 175827 bytes
Desc: not available
URL: <http://lists.puredata.info/pipermail/pd-list/attachments/20230429/01d2c5ee/attachment-0003.jpg>