[PD-dev] Re: PD-cvs Digest, Vol 21, Issue 30

[Thomas Grill]

Hi Mathieu,
>> i have been following the latst cvs changes and it seems, you are 
>> again beautifying the codebase.
>
> Please identify the parts that you consider that I'm just 
> "beautifying", apart from the files that don't belong to your part of 
> devel_0_39.
>
Actually, you should know what you changed. Only from the latest cvs digest:

> Message: 6
> Date: Tue, 28 Nov 2006 15:36:07 +0000
> From: Mathieu Bouchard <matju at users.sourceforge.net>
> Subject: [PD-cvs] pd/src x_list.c,1.2.2.7,1.2.2.8
> To: pd-cvs at iem.at
> Message-ID: <mailman.3.1164798002.5135.pd-cvs at iem.at>
>
> Update of /cvsroot/pure-data/pd/src
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv19418
>
> Modified Files:
>       Tag: devel_0_39
>     x_list.c
> Log Message:
> removed useless reference to global var "newest".
>
>
> Index: x_list.c
> ===================================================================
> RCS file: /cvsroot/pure-data/pd/src/x_list.c,v
> retrieving revision 1.2.2.7
> retrieving revision 1.2.2.8
> diff -C2 -d -r1.2.2.7 -r1.2.2.8
> *** x_list.c    30 Nov 2005 13:36:58 -0000    1.2.2.7
> --- x_list.c    28 Nov 2006 15:36:03 -0000    1.2.2.8
> ***************
> *** 21,27 ****
>   #endif
>
> - extern t_pd *newest;
> -
> -
>   /* the "list" object family.
>
> --- 21,24 ----
> ***************
> *** 397,419 ****
>   {
>       if (!argc || argv[0].a_type != A_SYMBOL)
> !         newest = list_append_new(s, argc, argv);
>       else
>       {
>           t_symbol *s2 = argv[0].a_w.w_symbol;
> !         if (s2 == gensym("append"))
> !             newest = list_append_new(s, argc-1, argv+1);
> !         else if (s2 == gensym("prepend"))
> !             newest = list_prepend_new(s, argc-1, argv+1);
> !          else if (s2 == gensym("split"))
> !             newest = list_split_new(atom_getfloatarg(1, argc, argv));
> !          else if (s2 == gensym("trim"))
> !             newest = list_trim_new();
> !         else
> !         {
> !             error("list %s: unknown function", s2->s_name);
> !             newest = 0;
> !         }
>       }
> -     return (newest);
>   }
>
> --- 394,408 ----
>   {
>       if (!argc || argv[0].a_type != A_SYMBOL)
> !         return list_append_new(s, argc, argv);
>       else
>       {
>           t_symbol *s2 = argv[0].a_w.w_symbol;
> !         if (s2 == gensym("append"))  return list_append_new(s, 
> argc-1, argv+1);
> !         if (s2 == gensym("prepend")) return list_prepend_new(s, 
> argc-1, argv+1);
> !         if (s2 == gensym("split"))   return 
> list_split_new(atom_getfloatarg(1, argc, argv));
> !         if (s2 == gensym("trim"))    return list_trim_new();
> !         error("list %s: unknown function", s2->s_name);
> !         return 0;
>       }
>   }
>
>
>
>
>
> ------------------------------
>
> Message: 7
> Date: Tue, 28 Nov 2006 15:46:11 +0000
> From: Mathieu Bouchard <matju at users.sourceforge.net>
> Subject: [PD-cvs] pd/src x_connective.c,1.3.4.1.2.8,1.3.4.1.2.9
> To: pd-cvs at iem.at
> Message-ID: <mailman.4.1164798002.5135.pd-cvs at iem.at>
>
> Update of /cvsroot/pure-data/pd/src
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv23183
>
> Modified Files:
>       Tag: devel_0_39
>     x_connective.c
> Log Message:
> removed useless access to "newest".
>
>
> Index: x_connective.c
> ===================================================================
> RCS file: /cvsroot/pure-data/pd/src/x_connective.c,v
> retrieving revision 1.3.4.1.2.8
> retrieving revision 1.3.4.1.2.9
> diff -C2 -d -r1.3.4.1.2.8 -r1.3.4.1.2.9
> *** x_connective.c    30 Nov 2005 13:36:58 -0000    1.3.4.1.2.8
> --- x_connective.c    28 Nov 2006 15:46:09 -0000    1.3.4.1.2.9
> ***************
> *** 9,13 ****
>   #include <string.h>
>   #include <stdio.h>
> - extern t_pd *newest;
>
>   /* -------------------------- int ------------------------------ */
> --- 9,12 ----
> ***************
> *** 67,71 ****
>       outlet_new(&x->x_obj, &s_float);
>       floatinlet_new(&x->x_obj, &x->x_f);
> -     newest = &x->x_obj.ob_pd;
>       return (x);
>   }
> --- 66,69 ----
> ***************
> *** 110,114 ****
>       outlet_new(&x->x_obj, &s_symbol);
>       symbolinlet_new(&x->x_obj, &x->x_s);
> -     newest = &x->x_obj.ob_pd;
>       return (x);
>   }
> --- 108,111 ----
> ***************
> *** 166,170 ****
>       t_bang *x = (t_bang *)pd_new(bang_class);
>       outlet_new(&x->x_obj, &s_bang);
> -     newest = &x->x_obj.ob_pd;
>       return (x);
>   }
> --- 163,166 ----
>
-- 
Thomas Grill
http://grrrr.org