[PD-dev] double menu bindings

[Dan Wilcox]

Right. Something weird is going on.

Digging into the man page, it says the accelerator string is just to *display* the key bindings and the -command invoaction is for when the menu is clicked. In that light, we obviously need both the key binding *and* the menu command.

I’ll do some more digging.

--------
Dan Wilcox
@danomatika <https://twitter.com/danomatika>
danomatika.com <http://danomatika.com/>
robotcowboy.com <http://robotcowboy.com/>
> On May 1, 2016, at 9:41 AM, Miller Puckette <msp at ucsd.edu> wrote:
> 
> Interesting... in my experience the "-accelerator" option (as used
> in ::pd_menus::build_put_menu) has never actually bound the menu selection
> to the associated keyboard event (so that I've also had to put a key binding
> in).  Maybe this is because I wasn't using the feature right somehow.
> Anyhow on my linux box (with tcl 8.5) I'm not getting double events so
> the difference isn't the tcl/tk version.  I don't know what's going on but
> clearly there's something wrong in the original code that manifests itself
> in your installation of Pd but not on most peoples'.
> 
> cheers
> M
> On Sat, Apr 30, 2016 at 10:59:55PM -0600, Dan Wilcox wrote:
>> On a related note to the zoom bindings, I’m wondering why we have keybindings for the canvas window in two places: pd_menus.tcl & pd_bindings.tcl?
>> 
>> When switching to tk 8.5 on Mac, I noticed that the iem gui creation hot keys (Shift+Command+B for bng, etc) result in 2 objects being created. This was not the case with Tk 8.4 and might be related to how the shift key was being handled.
>> 
>> Also, this is happening with *anything* that has a shift binding such as “Save As” opening 2 dialogs and “Redo” bing called twice.
>> 
>> Anyway, commenting out the -command settings for each men item that uses shift in ::pd::menus::build_put_menu fixes the issue as far as I can tell as the global key bindings catch it. This is something I’ll throw up into a branch when I lock down updates for tk 8.5 on OSX soon. It will need to be tested on other platforms.
>> 
>> --------
>> Dan Wilcox
>> @danomatika <https://twitter.com/danomatika>
>> danomatika.com <http://danomatika.com/>
>> robotcowboy.com <http://robotcowboy.com/>
> 
>> _______________________________________________
>> Pd-dev mailing list
>> Pd-dev at lists.iem.at
>> https://lists.puredata.info/listinfo/pd-dev
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.puredata.info/pipermail/pd-dev/attachments/20160501/914fdf06/attachment.html>